[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #4282 [Tor]: Extract common "make private stats dir" code from rephist.c, geoip.c

#4282: Extract common "make private stats dir" code from rephist.c, geoip.c
----------------------------------------+-----------------------------------
 Reporter:  nickm                       |          Owner:                    
     Type:  defect                      |         Status:  needs_review      
 Priority:  normal                      |      Milestone:  Tor: 0.2.5.x-final
Component:  Tor                         |        Version:                    
 Keywords:  easy refactoring tor-relay  |         Parent:                    
   Points:                              |   Actualpoints:                    
----------------------------------------+-----------------------------------
Changes (by nickm):

  * milestone:  Tor: unspecified => Tor: 0.2.5.x-final


Comment:

 Looks good to me for inclusion in 0.2.5.x once that forks.  We'll want to
 fix it up so it matches our indentation style for where braces go at the
 start of functions, and where tabs vs spaces go.  "make check-spaces"
 should catch some of these.

 It would be great to have unit tests for this.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4282#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs