[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #10640 [TorBrowserButton]: Fix about:tor's pointer position for RTL languages

#10640: Fix about:tor's pointer position for RTL languages
----------------------------------+---------------------------
     Reporter:  Sherief           |      Owner:  brade
         Type:  defect            |     Status:  needs_review
     Priority:  major             |  Milestone:
    Component:  TorBrowserButton  |    Version:
   Resolution:                    |   Keywords:  tbb-usability
Actual Points:                    |  Parent ID:
       Points:                    |
----------------------------------+---------------------------
Changes (by brade):

 * status:  assigned => needs_review


Comment:

 Mark and I committed a fix for this issue on the bug10640 branch, here:
 https://gitweb.torproject.org/user/brade/torbutton.git/commit/4f770c71c5ce0e76edd9e7d6698998f672ed4da9

 Previously, the code assumed that the Torbutton toolbar item was in a
 fixed/default location.  When the icon is to the right of the URL bar, its
 location changes when the window width changes, so a hard-coded position
 will not be correct (and users can customize the toolbars as well).  The
 new code gets the actual position of the Torbutton and makes the arrow
 point to it (if it is on the toolbar).

 Mike, please review and decide if you want to take this fix for 3.5.1.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/10640#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs