[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #9701 [Tor Browser]: Prevent TorBrowser from creating clipboardcache turds

#9701: Prevent TorBrowser from creating clipboardcache turds
-------------------------+-------------------------------------------------
     Reporter:           |      Owner:  mikeperry
  cypherpunks            |     Status:  needs_review
         Type:  defect   |  Milestone:
     Priority:  normal   |    Version:
    Component:  Tor      |   Keywords:  tbb-disk-leak, interview, tbb-
  Browser                |  firefox-patch, TorBrowserTeam201501R
   Resolution:           |  Parent ID:
Actual Points:           |
       Points:           |
-------------------------+-------------------------------------------------

Comment (by mcs):

 Kathy and I took a quick look at msvb9701-283f7c6.patch.  I am glad you
 found a way to make this approach work!

 I don't think we have to worry about non-Mozilla components calling
 DataStruct::SetData(); it looks like that method is only called from
 within nsTransferable.cpp (I am not sure why it is not declared inside
 nsTransferable.cpp instead of in the header).  Is that your conclusion as
 well?

 I would feel better if the old DataStruct::SetData() call that does not
 accept a aIsPrivBrowsing parameter was removed entirely (to avoid any
 chance that the wrong call could be made).  In fact, there is another call
 later in nsTransferable::SetTransferData() that should be modified to use
 the new method as well.

 One nit:  You should be able to just access the mPrivateData member
 directly instead of bothering with a call to GetIsPrivateData().

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9701#comment:30>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs