[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #17101 [Tor]: Tests for connection_ap_handshake_rewrite_and_attach

#17101: Tests for connection_ap_handshake_rewrite_and_attach
----------------------+------------------------------------
 Reporter:  ipazmino  |          Owner:
     Type:  defect    |         Status:  needs_revision
 Priority:  Medium    |      Milestone:  Tor: 0.2.8.x-final
Component:  Tor       |        Version:
 Severity:  Normal    |     Resolution:
 Keywords:  coverage  |  Actual Points:
Parent ID:            |         Points:  medium
  Sponsor:  SponsorS  |
----------------------+------------------------------------
Changes (by nickm):

 * status:  needs_review => needs_revision


Comment:

 Quick review:
    * Won't pass with --enable-gcc-warnings
    * Puts "http" in socks address, where it doesn't actually go.
    * The duplicated code in all these tests distracts from the actual
 intent of the test.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17101#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs