[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #17605 [Core Tor/Tor]: Tell caches to remove X-Your-Address-Is from Tor Directory documents

#17605: Tell caches to remove X-Your-Address-Is from Tor Directory documents
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  jryans
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  High                                 |      Milestone:  Tor:
                                                 |  0.3.0.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-auth, isaremoved,                |  Actual Points:
  tor-03-unspecified-201612, review-group-14     |
Parent ID:                                       |         Points:  2
 Reviewer:  nickm                                |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by nickm):

 This patch looks correct to me: it removes support for giving or taking
 the X-Your-Address-Is hint, and replaces it with looking at the netinfo
 hint instead.

 I have two questions about this patch -- arma or teor, could you give some
 feedback?

   * Should it ignore IPv6 addresses, because we can't publish them as a
 relay's primary address?  (I think "yes".)
   * Should it continue to give the X-Your-Address-Is answer for now, in
 case some relays actually need it? (Here I'm not sure.)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17605#comment:19>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs