[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #21134 [Core Tor/Tor]: Fail if file is too large to mmap.



#21134: Fail if file is too large to mmap.
--------------------------------------------+------------------------------
 Reporter:  junglefowl                      |          Owner:
     Type:  defect                          |         Status:
                                            |  needs_information
 Priority:  Medium                          |      Milestone:  Tor:
                                            |  0.3.0.x-final
Component:  Core Tor/Tor                    |        Version:  Tor: 0.2.9.8
 Severity:  Normal                          |     Resolution:
 Keywords:  tor_mmap_file, review-group-15  |  Actual Points:
Parent ID:                                  |         Points:
 Reviewer:  nickm                           |        Sponsor:
--------------------------------------------+------------------------------
Changes (by dgoulet):

 * status:  needs_review => needs_information


Comment:

 Wait, so normal behavior of gcc on 32 bit is that `off_t` and `size_t` are
 the same size so this still wouldn't work then?

 {{{
 if (st.st_size >= SIZE_MAX || size < st.st_size) {
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21134#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs