[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #21350 [Metrics/Atlas]: We should use CSS to style fingerprints, not <tt>



#21350: We should use CSS to style fingerprints, not <tt>
---------------------------+----------------------
 Reporter:  irl            |          Owner:  RaBe
     Type:  enhancement    |         Status:  new
 Priority:  Low            |      Milestone:
Component:  Metrics/Atlas  |        Version:
 Severity:  Normal         |     Resolution:
 Keywords:                 |  Actual Points:
Parent ID:  #21274         |         Points:
 Reviewer:                 |        Sponsor:
---------------------------+----------------------

Comment (by cypherpunks):

 I've been toying around with a solution to this issue and I've come up
 with the following patch.

 {{{
 diff --git a/templates/details/router.html b/templates/details/router.html
 index d94f5cf..f87001f 100644
 --- a/templates/details/router.html
 +++ b/templates/details/router.html
 @@ -72,7 +72,7 @@
      <% } %>

      <dt><span class="tip" data-content="20-byte unique identifier of the
 relay." data-original-title="Fingerprint">Fingerprint</span></dt>
 -    <dd><tt><%= relay.get('fingerprint').replace(/(.{20})/g,"$1&#8203;")
 %></tt></dd>
 +    <dd><pre><%= relay.get('fingerprint') %></pre></dd>

      <dt><span class="tip" data-content="Flags that the directory
 authorities assigned to this relay." data-original-title="Relay
 flags">Flags</span></dt>
      <dd><% _.each(relay.get('flags'), function(flag) { %>
 }}}

 It reverts the solution from #12685 because `<pre>` tags wrap their
 content automatically. However, using the `<pre>` tag changes the
 fingerprint to look like the fingerprints of the family members (except
 with black text instead of blue or orange). IMO this is preferable because
 it makes displaying fingerprints consistent but thought I'd mention it
 anyway.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21350#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs