Re: [tor-bugs] #24642 [Obfuscation/meek]: cannot use TOR_PT_EXIT_ON_STDIN_CLOSE with meek-client-torbrowser

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#24642: cannot use TOR_PT_EXIT_ON_STDIN_CLOSE with meek-client-torbrowser
------------------------------+------------------------------
 Reporter:  mcs               |          Owner:  dcf
     Type:  defect            |         Status:  needs_review
 Priority:  Medium            |      Milestone:
Component:  Obfuscation/meek  |        Version:
 Severity:  Normal            |     Resolution:
 Keywords:                    |  Actual Points:
Parent ID:  #24689            |         Points:
 Reviewer:                    |        Sponsor:
------------------------------+------------------------------

Comment (by mcs):

 Replying to [comment:7 dcf]:
 > The [https://gitweb.torproject.org/pluggable-
 transports/meek.git/log/?h=bug24642 bug24642] branch uses the `StdinPipe`
 idea.

 I tested it and it seems to work fine. Thanks!!!

 > I'm not totally happy with it, because ideally according to pt-spec, we
 should keep track of the stdin handle, and close it before sending
 anything like SIGTERM to the subprocess. But that would require more
 rewriting and is more than you need right now.

 Yes, we are happy with the simpler fix for now (but what you said does
 makes sense).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24642#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs