[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #22428 [Metrics/CollecTor]: Add webstats module



#22428: Add webstats module
-------------------------------+---------------------------------
 Reporter:  iwakeh             |          Owner:  iwakeh
     Type:  enhancement        |         Status:  needs_review
 Priority:  High               |      Milestone:  CollecTor 1.5.0
Component:  Metrics/CollecTor  |        Version:
 Severity:  Normal             |     Resolution:
 Keywords:  metrics-2018       |  Actual Points:
Parent ID:                     |         Points:
 Reviewer:                     |        Sponsor:
-------------------------------+---------------------------------

Comment (by karsten):

 Commit d18424a:
  - It looks like we're adding `sorted.first().minusDays(1)` but not
 `sorted.last().plusDays(1)`. I didn't try this out, but from looking at
 the code using this method it seems like we're excluding interval ends.
 Can you take another look?
  - Rest looks good.

 Commit 2dee32c looks good.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22428#comment:57>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs