[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #28780 [Core Tor/Tor]: circpadding: Add machine flag for not closing circuit if machine is active
#28780: circpadding: Add machine flag for not closing circuit if machine is active
-------------------------------------------------+-------------------------
Reporter: asn | Owner: (none)
Type: defect | Status:
| merge_ready
Priority: Medium | Milestone: Tor:
| 0.4.0.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: wtf-pad, tor-relay, tor-cell, | Actual Points:
padding |
Parent ID: #28632 | Points:
Reviewer: mikeperry | Sponsor:
-------------------------------------------------+-------------------------
Changes (by asn):
* status: needs_revision => merge_ready
Comment:
I pushed Mike's latest branch here so that CI runs:
https://github.com/torproject/tor/pull/644
I'm OK with the purpose-based approach, but now I see that we are using
both my "special flag" and also the "special purpose" so we moved from one
special thing to two. In this case, can you please motivate the new
purpose further in the docs of `CIRCUIT_PURPOSE_C_CIRCUIT_PADDING`. IIUC,
the new purpose is so that Tor does not attach
new streams to the circuit, or are there more reasons?
If that's the only reason, perhaps it would be wise to ask feedback from
Nick to see if a new purpose is the best way to achieve that goal.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28780#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs