[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #28590 [Core Tor/sbws]: Replace sbws tests/integration/net.tar with an unpacked version



#28590: Replace sbws tests/integration/net.tar with an unpacked version
------------------------------------------+--------------------------------
 Reporter:  teor                          |          Owner:  (none)
     Type:  defect                        |         Status:  merge_ready
 Priority:  Medium                        |      Milestone:  sbws:
                                          |  1.0.x-final
Component:  Core Tor/sbws                 |        Version:
 Severity:  Normal                        |     Resolution:
 Keywords:  sbws-1.0-nice-moved-20181128  |  Actual Points:
Parent ID:                                |         Points:
 Reviewer:  ahf                           |        Sponsor:
------------------------------------------+--------------------------------
Changes (by ahf):

 * status:  needs_review => merge_ready


Comment:

 This looks fine as far as I can tell.

 - It looks like the files that have been extracted are the same as in the
 tarball.
 - I did NOT go over the individual files to see if some of the code or
 config files could get some clean-up.

 Right now the Travis CI fails with what looks like an unrelated GPG
 failure. Please bump the Travis CI to make it pass before landing, but
 other than that it looks good to me.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28590#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs