[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #28894 [Applications/Tor Browser]: Remove Torbutton parts of fix for #20244

#28894: Remove Torbutton parts of fix for #20244
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-torbutton, TorBrowserTeam201901  |  Actual Points:
Parent ID:  #28745                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by mcs):

 * status:  needs_review => needs_revision
 * keywords:  tbb-torbutton, TorBrowserTeam201901R => tbb-torbutton,
     TorBrowserTeam201901


Comment:

 Kathy and I reviewed these changes and have a couple of comments:
 A) src/jar.mn includes a reference to privacy-prefs-overlay.xul which
 should be removed.
 B) Maybe we are missing something, but we think the following additional
 entities are no longer used (and therefore should be removed from the .dtd
 files):
 * torbutton.prefs.restrict_thirdparty
 * torbutton.prefs.restrict_thirdparty_tooltip
 * torbutton.prefs.resist_fingerprinting
 * torbutton.prefs.resist_fingerprinting_tooltip

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28894#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs