Re: [tor-bugs] #28226 [Core Tor/Tor]: Backend for an async publish-subcribe messaging system for cross-module communications

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#28226: Backend for an async publish-subcribe messaging system for cross-module
communications
-----------------------------------------+---------------------------------
 Reporter:  nickm                        |          Owner:  nickm
     Type:  enhancement                  |         Status:  needs_review
 Priority:  Medium                       |      Milestone:  Tor:
                                         |  0.4.1.x-final
Component:  Core Tor/Tor                 |        Version:
 Severity:  Normal                       |     Resolution:
 Keywords:  tor-pubsub, sponsor31-maybe  |  Actual Points:
Parent ID:                               |         Points:
 Reviewer:  catalyst                     |        Sponsor:  Sponsor31-can
-----------------------------------------+---------------------------------

Comment (by catalyst):

 Partial review so far, by commit:

   b7358da11 namemap::
     seems ok. I have a few misgivings about the type punning used for the
 temporary object, but it might be safe
   d26a213c9 `LD_MESG`::
     seems ok, except for needing to bump the total as mentioned above
   749456940 semicolon eater::
     seems ok. Maybe we want to uses this in ht.h, but that means changing
 all its users, so maybe not in this ticket
   33c20c70d smartlist_grow::
     seems ok, assuming the sizes bounds check in
 `smartlist_ensure_capacity()` is correct, which from a quick glance it
 seems to be

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28226#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs