[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #32806 [Core Tor/Tor]: Move "easy" dirauth-only options to dirauth module

#32806: Move "easy" dirauth-only options to dirauth module
---------------------------------+------------------------------------
 Reporter:  nickm                |          Owner:  nickm
     Type:  enhancement          |         Status:  needs_revision
 Priority:  Medium               |      Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor         |        Version:
 Severity:  Normal               |     Resolution:
 Keywords:  tor-design, 043-can  |  Actual Points:  0.5
Parent ID:  #32139               |         Points:
 Reviewer:  teor                 |        Sponsor:
---------------------------------+------------------------------------
Changes (by teor):

 * status:  needs_review => needs_revision
 * type:  defect => enhancement


Comment:

 Looks good, there's a bit of unused code you can delete if you like, and a
 comment that got a little mangled.
 Feel free to merge after fixing those issues.

 What's the plan to test these changes?
 There are some unit tests and chutney tests, but the coverage isn't great.

 Should we run the code on moria1 before merging? Or shortly after merging?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32806#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs