[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #32435 [Applications/Tor Browser]: Compile clang for Linux x86_64 with WASM support



#32435: Compile clang for Linux x86_64 with WASM support
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  task                                 |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-security, GeorgKoppen202001,     |  Actual Points:
  TorBrowserTeam202001                           |
Parent ID:  #32434                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by boklm):

 * keywords:  tbb-security, GeorgKoppen202001, TorBrowserTeam202001R => tbb-
     security, GeorgKoppen202001, TorBrowserTeam202001
 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:4 gk]:
 > `bug_32389` (https://gitweb.torproject.org/user/gk/tor-browser-
 build.git/commit/?h=bug_32389&id=298b18f9e1319077e8909b5ec43f270fbfabf405)
 has a build patch up for review.

 One small simplification: I think the line `rlbox: '[% c("var/nightly") &&
 c("var/linux-x86_64") %]'` can be moved to `targets/linux-x86_64` instead
 of `targets/linux`, so that the part `&& c("var/linux-x86_64")` can be
 removed.

 We can also remove the lines `rlbox: 0` for the other platforms, as it is
 disabled by default.

 With only one place where it is set, I think this makes it easier to see
 in which case it is enabled.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32435#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs