[tor-bugs] Re: #1612 [Tor - BridgeDB]: Group unreserved bridges into buckets for people

["Tor Bug Tracker & Wiki" <torproject-admin@xxxxxxxxxxxxxx>]

#1612: Group unreserved bridges into buckets for people
----------------------------+-----------------------------------------------
 Reporter:  phobos          |       Owner:  kaner                    
     Type:  task            |      Status:  assigned                 
 Priority:  normal          |   Milestone:  BridgeDB Upgrades Phase 1
Component:  Tor - BridgeDB  |     Version:                           
 Keywords:                  |      Parent:                           
----------------------------+-----------------------------------------------
Changes (by nickm):

  * status:  needs_review => assigned


Comment:

 Summarizing issues from IRC:

  * f.close doesn't close a file; you need to use f.close()
  * Suggestion to prefix names of pseudodistributors with pseudo: in the
 database to easily tell them apart from real ones without needing an
 exhaustive list of real distributors
  * Try pylint and pychecker
  * Tests would be good
  * next time you want to move a bunch of code and change it too, please do
 one patch that only moves the code, so it's easier to see what changed.
  * isBucketIdentKnown should return a bool, or should be renamed to
 getBucketByIdent or something

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1612#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online