[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #6239 [Stem]: Implement SETCONF/RESETCONF parsing in Stem
#6239: Implement SETCONF/RESETCONF parsing in Stem
--------------------+-------------------------------------------------------
Reporter: neena | Owner: neena
Type: task | Status: needs_review
Priority: normal | Milestone:
Component: Stem | Version:
Keywords: | Parent:
Points: | Actualpoints:
--------------------+-------------------------------------------------------
Comment(by atagar):
Hi Ravi. Looks pretty good, though I think that arm had a better api for
this. The SETCONF and RESETCONF do the exact same thing except for
undefined values (the two controller methods would probably be combined if
tor could break backward comparability). Stem's Controller shouldn't
blindly mirror the control-spec if we can do better. ;)
Pushed an alternative implementation to the 'setconf-wrapper' branch of my
personal repo...
https://gitweb.torproject.org/user/atagar/stem.git/shortlog/refs/heads
/setconf-wrapper
Changes made on top of yours...
https://gitweb.torproject.org/user/atagar/stem.git/commitdiff/80780e7
https://gitweb.torproject.org/user/atagar/stem.git/commitdiff/8b3c470
Thoughts?
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6239#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs