[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #12585 [Tor]: Implement new option SocksSocket



#12585: Implement new option SocksSocket
-----------------------------+-----------------
     Reporter:  ioerror      |      Owner:
         Type:  enhancement  |     Status:  new
     Priority:  normal       |  Milestone:
    Component:  Tor          |    Version:
   Resolution:               |   Keywords:
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+-----------------

Comment (by anon):

 I have reviewed the patch and it looks good! There is a
 SocksSocketsGroupWriteable option to support use by users who are not the
 tor user.

 The patch correctly handles non-applicable scenarios where IPV6 and other
 uses apply but not to AF_UNIX.

 Green for merge on my account!

 // P.S. I am testing some performance behavior with larger send and
 receive buffers for Unix domain sockets which may have a significant
 impact on throughput. If the benefit is large I will submit as another
 patch. The nature of buffer SOCKOPTs implies more time for testing on
 platforms for compatibility. (E.g. need additional configure / ifdefs for
 particular BSD socket options.)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12585#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs