[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #16276 [Onionoo]: bug in onionoo's family set detection



#16276: bug in onionoo's family set detection
-----------------------------+--------------------------
     Reporter:  cypherpunks  |      Owner:
         Type:  enhancement  |     Status:  needs_review
     Priority:  normal       |  Milestone:
    Component:  Onionoo      |    Version:
   Resolution:               |   Keywords:
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+--------------------------

Comment (by leeroy):

 It breaks the unit tests but not a huge deal until you're sure you want to
 commit. In your fixup you add back some of what was removed but you don't
 add back setFamilyFingerprints, which means getFamilyFingerprints will
 always return null. If your intention is to support both families fully
 you'll need to add back the setter and set it from NodeStatus (like
 before).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16276#comment:32>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs