[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #19018 [Metrics/CollecTor]: run CollecTor modules without crontab



#19018: run CollecTor modules without crontab
-------------------------------+---------------------------------
 Reporter:  iwakeh             |          Owner:  iwakeh
     Type:  enhancement        |         Status:  needs_review
 Priority:  Medium             |      Milestone:  CollecTor 1.0.0
Component:  Metrics/CollecTor  |        Version:
 Severity:  Normal             |     Resolution:
 Keywords:  ctip               |  Actual Points:
Parent ID:                     |         Points:
 Reviewer:                     |        Sponsor:
-------------------------------+---------------------------------

Comment (by karsten):

 That branch looks good, I don't have any major requests for changes.
 Please find [https://gitweb.torproject.org/karsten/metrics-
 db.git/log/?h=task-19018 my branch task-19018] with two commits, one with
 trivial whitespace fixes and one that fixes the properties template.  Let
 me know if you're okay with those changes.

 And would you mind if we avoid that merge commit by going back to the
 latest commit that is in master and your branch and cherry-picking
 subsequent commits?  I recognize that your branch is correct, but I
 remember having trouble with merges in the past, so I'm trying to rebase
 whenever I can.  And with only two developers this still seems doable.
 Happy to try this, and if the result is the same as your branch, except
 for slightly changed commit history, I'd push to master.  Sound okay?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19018#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs