[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #22804 [Core Tor/Tor]: Refactor circuit_send_next_onionskin() to be less horribly large

#22804: Refactor circuit_send_next_onionskin() to be less horribly large
-----------------------------+------------------------------------
 Reporter:  nickm            |          Owner:
     Type:  defect           |         Status:  merge_ready
 Priority:  Medium           |      Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor     |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:  refactor tor-hs  |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:                   |        Sponsor:  SponsorR
-----------------------------+------------------------------------
Changes (by dgoulet):

 * status:  needs_review => merge_ready


Comment:

 lgtm; thanks!

 (Of course, in an ideal world, we would unit tests the hell out of this if
 possible because `circuit_send_next_onion_skin()` has no unit test and
 it's pretty core.)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22804#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs