[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #20515 [Metrics/CollecTor]: CollecTor's relaydescs module should avoid httpurlconnection
#20515: CollecTor's relaydescs module should avoid httpurlconnection
-------------------------------+---------------------------------
Reporter: iwakeh | Owner: iwakeh
Type: enhancement | Status: needs_review
Priority: Medium | Milestone: CollecTor 1.2.0
Component: Metrics/CollecTor | Version:
Severity: Normal | Resolution:
Keywords: metrics-help | Actual Points:
Parent ID: #8799 | Points:
Reviewer: | Sponsor:
-------------------------------+---------------------------------
Changes (by iwakeh):
* status: accepted => needs_review
Comment:
Simply switching to file copy would mean a major change here as the
current download approach reads the data to memory for verifying and after
that writes to file(s).
A toy example of an http-server that accepts connections, but never writes
the response code yielded the stack-trace provided in #22602. The easiest
remedy is setting a read-timeout.
(A quick inspection of the code that gets used when using Files.copy
indicates that a timeout seems to be set there, too.)
Open points:
* the current read timeout is arbitrarily set to 5000ms. How to find the
best value?
* Should a connect timeout be set, too? There is no bug report that
indicates necessity for this timeout type.
Please review
[https://gitweb.torproject.org/user/iwakeh/collector.git/commit/?h=task-20515&id=0411ec816ed9298cc657309af96432027348f014
this change].
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20515#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs