[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #13398 [Applications/Tor Browser]: at startup, browser gleans user FULL NAME (real name, given name) from O/S

#13398: at startup, browser gleans user FULL NAME (real name, given name) from O/S
--------------------------------------+--------------------------------
 Reporter:  zinc                      |          Owner:  pospeselr
     Type:  defect                    |         Status:  needs_revision
 Priority:  Medium                    |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  TorBrowserTeam201707R     |  Actual Points:
Parent ID:                            |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+--------------------------------
Changes (by mcs):

 * status:  needs_review => needs_revision


Comment:

 I was unable to apply the 13398-pospeselr.patch; it looks like trailing
 whitespace has been removed from the patch. In any case, we typically
 avoid touching lines that we are not otherwise changing because larger
 patches are more work to maintain (but hopefully we can convince Mozilla
 to accept this patch upstream).

 After I manually applied the patch, I then encountered a linker error
 while building on OSX (I attempted a non-gitian build). To fix the
 problem, I had to add an empty destructor to
 `toolkit/components/startup/nsUserInfoMac.mm`:
 {{{
 nsUserInfo::~nsUserInfo() {}
 }}}
 Using userinfotest.xpi I verified that the fix is effective. Good work!

 I have mixed feelings about refactoring the OSX nsUserInfo implementation.
 This seems like a good clean up, but this also may make patch maintenance
 more difficult.

 Please match the style of most other Mozilla code for the `if` statements
 (include a space after `if`).

 In the code that calls `ToNewUnicode()` it would be slightly more compact
 to directly assign to the output parameter, e.g.,
 {{{
 NS_IMETHODIMP
 nsUserInfo::GetFullname(char16_t** aFullname)
 {
   NS_ENSURE_ARG_POINTER(aFullname);

   if (sHideUserInfo) {
     *aFullname = ToNewUnicode(NS_LITERAL_STRING(""));
     if (aFullname) {
       return NS_OK;
     }

     return NS_ERROR_FAILURE;
   }

   return this->GetFullnameImpl(aFullname);
 }
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13398#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs