[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #26766 [Core Tor/Stem]: Cell unused content is ignored while packing

#26766: Cell unused content is ignored while packing
---------------------------+------------------------------
 Reporter:  dmr            |          Owner:  dmr
     Type:  defect         |         Status:  needs_review
 Priority:  Medium         |      Milestone:
Component:  Core Tor/Stem  |        Version:
 Severity:  Normal         |     Resolution:
 Keywords:  client         |  Actual Points:
Parent ID:                 |         Points:
 Reviewer:  atagar         |        Sponsor:
---------------------------+------------------------------
Changes (by dmr):

 * status:  assigned => needs_review


Comment:

 Ok, here's the pull request:
 https://github.com/torproject/stem/pull/5
 Branch head `775bc60fb6497872b8ae00a5a8b5c3e29305d7d0`.

 I made a nice little `--no-ff` merge commit already - hopefully that helps
 with the summary :)

 I took the opportunity to refactor a lot of the cell test cases. This
 should make it much easier to add further test cases for `unused` or
 `link_protocol` differences. It also makes it much more data-driven than
 before.

 The main implementation change is here:
 [[https://github.com/torproject/stem/pull/5/commits/b00100d73410850d245cb1d1666829748f41ad69|b00100d73410850d245cb1d1666829748f41ad69]]

 The main test additions are here:
 [[https://github.com/torproject/stem/pull/5/commits/15b71235d7151465047afbe10b010bd0d82cb917|15b71235d7151465047afbe10b010bd0d82cb917]]
 [[https://github.com/torproject/stem/pull/5/commits/9c931591a7ef4ffa2f82f3d7c970c2fcb584ae9a|9c931591a7ef4ffa2f82f3d7c970c2fcb584ae9a]]
 [[https://github.com/torproject/stem/pull/5/commits/dc7be2c5faa9675279a3e9da263f2975e78ef762|dc7be2c5faa9675279a3e9da263f2975e78ef762]]
 [[https://github.com/torproject/stem/pull/5/commits/5f3376a1d0e569a4573d474a6dd13646beb82c8a|5f3376a1d0e569a4573d474a6dd13646beb82c8a]]
 [[https://github.com/torproject/stem/pull/5/commits/205536e63269de39fe2d878fefdf81c4bec786f4|205536e63269de39fe2d878fefdf81c4bec786f4]]
 [[https://github.com/torproject/stem/pull/5/commits/05ddc71784a196bdbc6e02d60eae453d5a32c6ad|05ddc71784a196bdbc6e02d60eae453d5a32c6ad]]

 Most of the rest is refactoring or minor stuff.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26766#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs