[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #3723 [Core Tor/Tor]: Report version of bwscanners in votes



#3723: Report version of bwscanners in votes
-------------------------------------------------+-------------------------
 Reporter:  mikeperry                            |          Owner:  (none)
     Type:  enhancement                          |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.5.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-bwauth, 035-triaged-in-20180711  |  Actual Points:
Parent ID:  #25925                               |         Points:
 Reviewer:  teor                                 |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by teor):

 Replying to [comment:26 juga]:
 > Rebased to master and continuing on
 ​https://github.com/torproject/tor/pull/195.

 Hi Juga,

 Please see my branch ticket3723_03 on https://github.com/teor2345/tor.git

 I did some small fixups:
 * removed a redundant header,
 * added a missing cast on Windows, and
 * fixed some code that was in the wrong place.

 I also wrote a spec for parsing failures in #26799, and implemented it.

 Please review https://github.com/torproject/tor/pull/231

 If you're happy with the code, please:
 * run it against a test bandwidth file, and check the vote contents
 * squash all your fixups (and my fixups, if you want)
 * rebase to the latest master

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3723#comment:33>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs