[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #26540 [Applications/Tor Browser]: Enabling pdfjs disableRange option prevents pdfs from loading

#26540: Enabling pdfjs disableRange option prevents pdfs from loading
---------------------------------------------+-----------------------------
 Reporter:  pospeselr                        |          Owner:  pospeselr
     Type:  defect                           |         Status:
                                             |  needs_review
 Priority:  Medium                           |      Milestone:
Component:  Applications/Tor Browser         |        Version:
 Severity:  Normal                           |     Resolution:
 Keywords:  ff60-esr, TorBrowserTeam201807R  |  Actual Points:
Parent ID:                                   |         Points:
 Reviewer:                                   |        Sponsor:
---------------------------------------------+-----------------------------

Comment (by pospeselr):

 So this updated patch shows the general approach here of smuggling the
 first-party domain on the channel object directly as a fallback in case
 the domain stored on the origin attributes is empty-string (as is the case
 for XMLHttpRequests made under the System Principal.

 I think the final patch (assuming y'all are ok with this approach) would
 stow the smuggled first-party domain on the nsIHttpChannel, rather than
 the nsIPrivateBrowsingChannel (since almost everything implements the
 private browsing interface, but we only need it on the http channel).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26540#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs