[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

[tor-bugs] Re: #1139 [Tor - Tor client]: alpha gcc bug: circuitbuild.c:608: circuit_build_times_generate_sample: Assertion q_lo < q_hi failed

#1139: alpha gcc bug: circuitbuild.c:608: circuit_build_times_generate_sample:
Assertion q_lo < q_hi failed
-------------------------------+--------------------------------------------
  Reporter:  weasel            |       Owner:  nickm        
      Type:  defect            |      Status:  assigned     
  Priority:  minor             |   Milestone:               
 Component:  Tor - Tor client  |     Version:  0.2.2.5-alpha
Resolution:  None              |    Keywords:               
    Parent:                    |  
-------------------------------+--------------------------------------------
Changes (by nickm):

  * owner:  => nickm
  * status:  new => assigned


Comment:

 We could close as wontfix; if somebody wants to investigate further, the
 right place to start is by doing a gcc -S to see what assembly it
 generates for the -O2 and -O0 cases.

 But the code in question sets off a smell-test of mine; instead of doing
 (X*rand_uint64() ) / (1.0*UINT64_MAX) , we should just have a function
 that returns a random double.  That should work around this issue just
 fine.

 I've added a branch, "rand_double", in my public to do this.  I'll hold
 off merging it until mikeperry's cbt-bugfixes3 branch is merged, since
 giving him more conflicts on that would not be a nice thing to do.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1139#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online