[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #4345 [Tor Relay]: Bug: closing wedged cpuworker.

#4345: Bug: closing wedged cpuworker.
-----------------------+----------------------------------------------------
 Reporter:  jn         |          Owner:                     
     Type:  defect     |         Status:  needs_review       
 Priority:  normal     |      Milestone:  Tor: unspecified   
Component:  Tor Relay  |        Version:  Tor: 0.2.3.10-alpha
 Keywords:             |         Parent:                     
   Points:             |   Actualpoints:                     
-----------------------+----------------------------------------------------

Comment(by ln5):

 If I'm reading _connection_write_to_buf_impl() correctly, a non OR
 connection will never be flushed (unless zlib is true, which it's not
 when coming from connection_write_to_buf()) -- ssize_t extra is set
 only for CONN_TYPE_OR.  This looks like a bug -- the comment says /*
 just try to flush all of it */ but that won't happen.

 For our case, it might not help fixing this.  Will
 conn->outbuf_flushlen really be >= 1<<16?

 Should we bother making the flushing work for this case or just force
 a flush in assign_onionskin_to_cpuworker()?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4345#comment:22>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs