[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #4795 [Firefox Patch Issues]: TBB does not like the standard theme on Windows XP, Vista, and 7



#4795: TBB does not like the standard theme on Windows XP, Vista, and 7
-------------------------------------+--------------------------------------
    Reporter:  runa                  |       Owner:  mikeperry      
        Type:  defect                |      Status:  needs_review   
    Priority:  major                 |   Milestone:                 
   Component:  Firefox Patch Issues  |     Version:                 
  Resolution:                        |    Keywords:  MikePerry201206
      Parent:                        |      Points:                 
Actualpoints:                        |  
-------------------------------------+--------------------------------------

Comment(by mikeperry):

 Replying to [comment:50 Shondoit]:
 > Replying to [comment:49 mikeperry]:
 > > We still need it so that non-mozilla extensions report the display
 size as the desktop size, and to prevent a whole lot of other unrelated
 leaky Mozilla extensions from being exposed to the content window.
 > That's where I went wrong, sorry. I revised my branch to limit it to the
 root view only instead of chrome, and thus eliminating the exposure to
 extensions.

 Actually, you might not be wrong here. It may just be miscommunication.
 When I said "Mozilla extensions" I meant the Media Query extensions, not
 addons. Closer look at your patch seems to indicate that you did in fact
 cover all the fingerprinting-related ones directly.

 As for IsRoot() vs IsChrome(), I think we *do* want addons to have access
 to the Mozilla extensions, so they don't suffer the same UI issues. I
 think that means we do want IsChrome() after all? If you agree, I can
 change it myself as I merge your patch.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4795#comment:54>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs