Re: [tor-bugs] #6249 [Vidalia]: Show amount of traffic in connections list in Network Map window.

["Tor Bug Tracker & Wiki" <torproject-admin@xxxxxxxxxxxxxx>]

#6249: Show amount of traffic in connections list in Network Map window.
-------------------------+--------------------------------------------------
 Reporter:  cypherpunks  |          Owner:  chiiph        
     Type:  enhancement  |         Status:  needs_revision
 Priority:  minor        |      Milestone:                
Component:  Vidalia      |        Version:                
 Keywords:               |         Parent:                
   Points:               |   Actualpoints:                
-------------------------+--------------------------------------------------
Changes (by chiiph):

  * status:  new => needs_revision


Comment:

 I like the idea. A couple of comments for your patch:

 - Why have you chosen to make the change in the if condition in
 Stream.cpp?
 - You should remove the commented emit LogMessage in TorEvents.cpp
 - The following if:

 {{{
 if (msg.size() >= 3) {
 }}}

 Should be:
 {{{
 if (msg.size() > 3) {
 }}}

 Otherwise if the msg.size() is == 3, then you can't access the 4th
 element.

 - In StreanItem.cpp, the _bytesReceived and _bytesSent initialization
 should be done as a part of the constructor init list.

 - Methods bytesReceived() and bytesSent() should be const.

 - You should upload a format-patch or a branch in some public git repo
 that I can merge, so you get credit for this patch.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6249#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs