[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #19021 [Metrics/CollecTor]: improve configuration process



#19021: improve configuration process
-------------------------------+-----------------------------
 Reporter:  iwakeh             |          Owner:  iwakeh
     Type:  enhancement        |         Status:  merge_ready
 Priority:  High               |      Milestone:
Component:  Metrics/CollecTor  |        Version:
 Severity:  Normal             |     Resolution:
 Keywords:  ctip operation     |  Actual Points:
Parent ID:                     |         Points:
 Reviewer:                     |        Sponsor:
-------------------------------+-----------------------------

Comment (by iwakeh):

 Thanks for looking at this so soon!

 The properties file will be explained in the future operation
 instructions. So, it shouldn't be confusing, I hope.

 I totally agree to have handy commits. But I'm very reluctant to commit
 any code that doesn't
 compile or fails tests. So, I couldn't find a shorter way of committing it
 w/o introducing some
 weirdness like having both Configuration.java classes in different
 packages or similar.

 Regarding the merge:
 We don't have a release yet and the configuration change is not reflected
 in the shell scripts,
 that's why I would not merge it to collector.git master branch.

 Instead, maybe add this branch to collector.git and once there is a
 scheduler patch branch based
 on this branch, both can be merged to the main collector.git master
 branch?
 Once the branch is added to the main collector.git this ticket could be
 closed as fixed.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19021#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs