[tor-bugs] #22495 [Core Tor/Tor]: Partial write in key-pinning-journal results in corrupted line

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#22495: Partial write in key-pinning-journal results in corrupted line
------------------------------+--------------------------------
     Reporter:  asn           |      Owner:
         Type:  defect        |     Status:  new
     Priority:  Low           |  Milestone:  Tor: 0.3.2.x-final
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:  easy tor-dirauth
Actual Points:                |  Parent ID:
       Points:  0.1           |   Reviewer:
      Sponsor:                |
------------------------------+--------------------------------
 Tor sees a corrupted line in its `key-pinning-journal` because of a
 truncated line:

 {{{
 @opened-at 2016-08-07 20:49:24
 wyD2E2ZG/fDQFbiQbz63VcvSKFo TNh6rQcairXqej0dOoRWOF93Zra+o+x+9b0VbiAG8zI
 DahGjy7upvyovkp1sJ1C+/wKmT4 TNh6rQcairXqej0dOoRWOF93Zra+o+x+9b0VbiAG8zI
 ...
 wyD2E2ZG/fDQFbiQbz63VcvSKFo TNh6rQcairXqej0dOoRWOF93Zra+o+x+9b0VbiAG8zI
 DahGjy7upvyovkp1sJ1C+/wKmT4 TNh6rQcairXq
 @opened-at 2016-10-05 20:02:15
 DahGjy7upvyovkp1sJ1C+/wKmT4 TNh6rQcairXqej0dOoRWOF93Zra+o+x+9b0VbiAG8zI
 }}}

 Nick says Tor uses fwrite()` when it should be using `write()` to write to
 that file.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22495>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs