[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #22608 [Core Tor/Tor]: Refactor connection_or_set_state(OPEN) to connection_or_set_state_open()

#22608: Refactor connection_or_set_state(OPEN) to connection_or_set_state_open()
-----------------------------+------------------------------------
 Reporter:  nickm            |          Owner:  nickm
     Type:  enhancement      |         Status:  needs_revision
 Priority:  Medium           |      Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor     |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:  review-group-18  |  Actual Points:
Parent ID:                   |         Points:  .2
 Reviewer:                   |        Sponsor:
-----------------------------+------------------------------------
Changes (by catalyst):

 * status:  needs_review => needs_revision


Comment:

 Looks mostly good.  A few nits: callgraph reduction numbers don't match
 between commit message and this ticket; also it fails check-spaces.  If
 it's a factor-of-three reduction in the largest SCC then maybe it should
 get a changes file, too?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22608#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs