[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #22476 [Metrics/metrics-lib]: Replace ImplementationNotAccessibleException with RuntimeException

#22476: Replace ImplementationNotAccessibleException with RuntimeException
---------------------------------+-----------------------------------
 Reporter:  karsten              |          Owner:  metrics-team
     Type:  enhancement          |         Status:  needs_review
 Priority:  Medium               |      Milestone:  metrics-lib 2.0.0
Component:  Metrics/metrics-lib  |        Version:
 Severity:  Normal               |     Resolution:
 Keywords:                       |  Actual Points:
Parent ID:                       |         Points:
 Reviewer:                       |        Sponsor:
---------------------------------+-----------------------------------

Comment (by karsten):

 Meh. `ProviderNotFoundException` doesn't have a constructor that accepts a
 `Throwable`. Maybe we shouldn't pick unrelated runtime exceptions and
 simply use `RuntimeException`. After all, we don't want people to catch
 them and distinguish them by type anyway, and the message will be
 sufficient to track down the issue.

 I also took out the log message change and linked the discussion here in
 #20430. Let's tackle that together with other logging changes.

 Please review [https://gitweb.torproject.org/user/karsten/metrics-
 lib.git/log/?h=task-22476 my branch task-22476] for 2.0.0.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22476#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs