[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #24104 [Core Tor/Tor]: Delay descriptor bandwidth reporting on large relays
#24104: Delay descriptor bandwidth reporting on large relays
-------------------------------------------------+-------------------------
Reporter: teor | Owner: juga
Type: enhancement | Status:
| assigned
Priority: Medium | Milestone: Tor:
| unspecified
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: guard-discovery-stats, chutney- | Actual Points:
wants, bwauth-wants, 034-triage-20180328, |
034-removed-20180328 |
Parent ID: #25925 | Points: 1
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Comment (by teor):
Replying to [comment:13 juga]:
> Is the place to do this change `check_descriptor_bandwidth_changed`
(https://gitweb.torproject.org/tor.git/tree/src/or/router.c#n2629)?
>
> If i've the line
https://gitweb.torproject.org/tor.git/tree/src/or/router.c#n2643 as:
> `if (get_uptime() < 60*60*24 && last_changed+MAX_BANDWIDTH_CHANGE_FREQ <
now || !prev)`, then the descriptor would still be uploaded when there is
not `prev`.
>
> Should instead i do `get_uptime() > 60*60*24 return;` at the beginning
of the function so that there are not any further checks when the relay is
up for more than 1 day?
Yes, but please make `60*60*24` a named #define with a comment. It should
be like MAX_BANDWIDTH_CHANGE_FREQ.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24104#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs