[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #8323 [Core Tor/Tor]: Missing 'GETINFO md/all'



#8323: Missing 'GETINFO md/all'
----------------------------------------------+----------------------------
 Reporter:  atagar                            |          Owner:  rl1987
     Type:  enhancement                       |         Status:
                                              |  needs_revision
 Priority:  High                              |      Milestone:  Tor:
                                              |  0.3.5.x-final
Component:  Core Tor/Tor                      |        Version:
 Severity:  Normal                            |     Resolution:
 Keywords:  tor-client tor-control microdesc  |  Actual Points:
Parent ID:                                    |         Points:
 Reviewer:  asn                               |        Sponsor:
----------------------------------------------+----------------------------
Changes (by asn):

 * status:  needs_review => needs_revision


Comment:

 Thanks for the code!

 I did an initial review on your PR! Some small changes will be needed, but
 you are pretty much there.

 Also, perhaps we should have some unittests for this new control command.
 SEe `src/test/test_controller.c` for some examples of other getinfo
 unittests.

 Cheers!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8323#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs