[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #26203 [Applications/Tor Browser]: Adapt tor-browser-build firefox and tor-browser project for ESR 60 Windows build



#26203: Adapt tor-browser-build firefox and tor-browser project for ESR 60 Windows
build
---------------------------------------------+-----------------------------
 Reporter:  gk                               |          Owner:  tbb-team
     Type:  task                             |         Status:
                                             |  needs_review
 Priority:  Very High                        |      Milestone:
Component:  Applications/Tor Browser         |        Version:
 Severity:  Normal                           |     Resolution:
 Keywords:  ff60-esr, TorBrowserTeam201806R  |  Actual Points:
Parent ID:                                   |         Points:
 Reviewer:                                   |        Sponsor:
---------------------------------------------+-----------------------------

Comment (by boklm):

 Replying to [comment:4 sukhbir]:
 > For review:
 >
 > https://github.com/azadi/tor-browser-build-1/tree/bug-26203

 Thanks. I will review, and suggest some fixup commits if needed.

 >
 > 2. I think we can do better for #26205 (commit
 `93f89a735792e329bd7853bcbd0db056426e32d6`). Please review and suggest.
 Also, should this patch go in Firefox (as part of `git_url`) or as
 separate patches which we add during the build (current approach)?

 I think the patch should go in `tor-browser.git` (but adding it as a patch
 file is useful for testing before it is merged in `tor-browser.git`).

 > 4. For Rust, I made the change below; let me know if we should remove
 the guards altogether:
 >
 > {{{
 > -[% IF ! c("var/windows") %]
 > +[% IF ! c("var/windows-i686") %]
 > }}}

 I think we can remove the guards altogether, as we will want it at some
 point, and the build fails without rust.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26203#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs