[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #26233 [Applications/Tor Browser]: Rebase Tor Browser patches for FF61
#26233: Rebase Tor Browser patches for FF61
-----------------------------------------------+---------------------------
Reporter: sysrqb | Owner:
| arthuredelstein
Type: enhancement | Status:
| needs_review
Priority: Very High | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: TorBrowserTeam201806R, tbb-mobile | Actual Points:
Parent ID: #25741 | Points:
Reviewer: | Sponsor:
-----------------------------------------------+---------------------------
Changes (by arthuredelstein):
* status: needs_information => needs_review
Comment:
Replying to [comment:10 gk]:
> What's the reason for doing
> {{{
> > - rv =
nsXREDirProvider::GetUserAppDataDirectory(getter_AddRefs(file));
> > + rv = mDirProvider.GetUserAppDataDirectory(getter_AddRefs(file));
> }}}
> essentially reverting bug 1443080 and deviating from the fix pattern
using the `GetSingleton()`-approach?
We're reverted that piece of 1443080 because in our patch, the methods are
no longer static. (That bug was removing instance calls to static
functions.) We could use either pattern, but because mDirProvider is
already available and used commonly in that file it seemed OK.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26233#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs