[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #25552 [Core Tor/Tor]: prop224: Onion service rev counters are useless and actually harmful for scalability

#25552: prop224: Onion service rev counters are useless and actually harmful for
scalability
-----------------------------------------------+---------------------------
 Reporter:  asn                                |          Owner:  dgoulet
     Type:  defect                             |         Status:
                                               |  needs_review
 Priority:  Medium                             |      Milestone:  Tor:
                                               |  0.3.5.x-final
Component:  Core Tor/Tor                       |        Version:  Tor:
                                               |  0.3.1.9
 Severity:  Normal                             |     Resolution:
 Keywords:  tor-hs prop224 034-roadmap-master  |  Actual Points:
Parent ID:                                     |         Points:  6+++
 Reviewer:  asn                                |        Sponsor:
-----------------------------------------------+---------------------------
Changes (by asn):

 * status:  new => needs_review
 * points:  4 => 6+++


Comment:

 Oooff! I have a branch that implements the OPE design for HSv3! It seems
 to work on my onion service for the past week just fine, and tests pass.
 This was much harder than I thought, because the `hs_service` unittests
 are a mess that depend on too many time sources. I fixed them all and
 tested them with various kinds of local time using
 [https://gist.github.com/asn-d6/41f3beefffb255904627f341cf34e5cc a crazy
 bash script] I hacked up.

 You can find a fixup for the spec branch at `ope_spec` in my github
 torspec repo. It explains why we cannot use "seconds since TP", and why we
 have to use "seconds since SRV".

 You can find the code at my branch `bug25552_ope_draft`. It seems to work
 fine and the code is decent, but I labeled it as draft because there might
 be some trivial code-style improvements that can be done (in particular im
 thinking the `is_current` func argument). I also '''need to make sure that
 HSes will not burp if they have an obsolete rev-counter left in their
 state file'''. Please check it out and if you like it I will make it real
 proper: https://github.com/torproject/tor/pull/150

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25552#comment:32>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs