[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #23561 [Applications/Tor Browser]: Fix nsis builds for Windows 64



#23561: Fix nsis builds for Windows 64
-------------------------------------------+------------------------------
 Reporter:  boklm                          |          Owner:  tbb-team
     Type:  task                           |         Status:  needs_review
 Priority:  Medium                         |      Milestone:
Component:  Applications/Tor Browser       |        Version:
 Severity:  Normal                         |     Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201806  |  Actual Points:
Parent ID:                                 |         Points:
 Reviewer:                                 |        Sponsor:
-------------------------------------------+------------------------------
Changes (by sukhbir):

 * status:  needs_revision => needs_review


Comment:

 Replying to [comment:24 boklm]:
 > Replying to [comment:23 boklm]:
 > > In `projects/nsis/build` there is a line `[% IF c("var/windows") %]`,
 but this `IF` is always true as we only build `nsis` for Windows. So I
 think the `IF` can be removed.
 >
 > In `projects/nsis/config` the line `enable: '[% c("var/windows") %]'`
 can also be removed.

 Thanks, I removed the `c("var/windows")` guard for zlib in both the build
 and the config files. (Same branch for review.)

 https://github.com/azadi/tor-browser-build-1/commits/bug-23561

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23561#comment:25>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs