[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #26475 [Applications/Tor Browser]: ESR60-based .dmg images are not built reproducibly with Stylo enabled using rustc > 1.25.0 (was: ESR60-based .dmg images are not built reproducibly with Stylo enabled)



#26475: ESR60-based .dmg images are not built reproducibly with Stylo enabled using
rustc > 1.25.0
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_information
 Priority:  Very High                            |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201806,       |  Actual Points:
  GeorgKoppen201806                              |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by gk):

 * status:  new => needs_information
 * cc: manishearth@…, acrichton@… (added)


Comment:

 As I expected this is a problem introduced by us switching to 1.26.1.
 Using version 1.25.0 of the Rust compiler `XUL` is still reproducible. So,
 to sum up:

 Starting with the switch to Rust 1.26.1 Tor Browser for macOS (and only
 for that platform) is not being built reproducibly anymore, once we enable
 Stylo. There are small differences visible in `XUL` stemming from `gkrust`
 (see: comment:1 and comment:4). Using either Rust 1.25.0 or disabling
 Stylo (what we are doing right now) is "solving" this problem.

 Alex, Manish: Do you know of any commit that could have caused this? If
 not, I can bisect I guess.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26475#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs