[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #30628 [Core Tor/Tor]: sendme closes client connections
#30628: sendme closes client connections
-------------------------------------------------+-------------------------
Reporter: traumschule | Owner: dgoulet
Type: defect | Status:
| needs_review
Priority: Medium | Milestone: Tor:
| 0.4.1.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: sendme, tor-flowctrl, 041-must | Actual Points: 0.6
041-regression regression |
Parent ID: | Points:
Reviewer: nickm | Sponsor:
-------------------------------------------------+-------------------------
Changes (by dgoulet):
* status: assigned => needs_review
* reviewer: => nickm
* actualpoints: => 0.6
Comment:
Oooooooooooook finally found the problem and figured out WHY this would
never happen with debug logs on. Problem is in this function that is
responsible for decrementing the flow control package window, can you spot
it? :
{{{
int
sendme_note_stream_data_packaged(edge_connection_t *conn)
{
tor_assert(conn);
log_debug(LD_APP, "Stream package_window now %d.",
--conn->package_window);
return conn->package_window;
}
}}}
Now imagine yourself with a tor with debug logs turned *off*, you know
like 99.9999% of the tor daemon out there ;).
Answer to the quiz is: `package_window` does NOT get decremented if
`log_debug` is off ;).......
I get the `commit hat of shame` for at least a full week there ;)....
Introduced in commit `3835a3acf57426f692a787e7729de929b40dc62e`.
Branch: `ticket30628_041_01`
PR: https://github.com/torproject/tor/pull/1071
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30628#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs