[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #30943 [Applications/Tor Browser]: Show Tor Browser version on Android



#30943: Show Tor Browser version on Android
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:  new
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-mobile, tbb-parity, tbb-         |  Actual Points:
  torbutton                                      |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by mcs):

 Replying to [comment:1 gk]:
 > We have
 > {{{
 >     <div id="torbrowser-info">
 >       <div id="torbrowser-version"/>
 >       <div id="torbrowser-changelog-link"><a
 href="about:tbupdate">&aboutTor.viewChangelog.label;</a></div>
 >     </div>
 > }}}
 > in `aboutTor.xhtml` and
 > {{{
 > body[mobile] #torbrowser-info,
 > body[mobile] .searchbox,
 > body[mobile] .top .heading2,
 > body[mobile] #manual,
 > body[mobile] #mission {
 >   display: none;
 > }
 > }}}
 > Which is presumably why the version number is not shown on mobile. It's
 not clear why we decided to not show all the things in `torbrowser-info`
 on mobile but sysrqb thinks that might be due to `about:tbupdate` not be
 available there. I guess we could just set `display:none;` on mobile for
 `torbrowser-changelog-link` instead?

 I think so, yes.
 Most of the hidden items were added during the #27111 work (commit
 61deb44d0c07eb1ec1d71eac2f0a7aeca87ea054). Kathy and I introduced
 #torbrowser-info during our work on #29440 (commit
 82a5f8665a6b5a7f5d4c78f0a526dfa16834ec7f).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30943#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs