[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #30721 [Core Tor/Tor]: tor_addr_port_lookup() is overly permissive
#30721: tor_addr_port_lookup() is overly permissive
-------------------------------------------------+-------------------------
Reporter: teor | Owner: teor
Type: defect | Status:
| needs_review
Priority: Medium | Milestone: Tor:
| 0.4.2.x-final
Component: Core Tor/Tor | Version: Tor:
| unspecified
Severity: Normal | Resolution:
Keywords: technical-debt, tor-addr, refactor, | Actual Points: 1.5
practracker-improvement |
Parent ID: | Points: 0.5
Reviewer: catalyst | Sponsor:
| Sponsor31-can
-------------------------------------------------+-------------------------
Changes (by teor):
* status: needs_information => needs_review
Comment:
Replying to [comment:7 catalyst]:
> Thanks! The new tests look reasonable. I wonder if it's necessary to
make all those multi-statement macro definitions, instead of helper
functions (and maybe much smaller macros that call those functions)? I
think helper function would be a little cleaner. Please let me know what
you think.
The problem with helper functions is that failures are attributed to the
test assertions in the helper function, without any context. So it's very
hard to tell which test data caused the failure.
I'm not sure if there is some way of providing context as part of the test
macros. I suggest that we merge this code as-is, because it's functional,
adds coverage, and makes sure we won't introduce future bugs. Then we can
open a ticket for follow-up.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30721#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs