[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #30984 [Core Tor/Tor]: Make a key-value line abstraction to output control replies



#30984: Make a key-value line abstraction to output control replies
--------------------------+------------------------------------
 Reporter:  catalyst      |          Owner:  catalyst
     Type:  defect        |         Status:  assigned
 Priority:  Medium        |      Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:  #29210        |         Points:  5
 Reviewer:                |        Sponsor:  Sponsor31-can
--------------------------+------------------------------------

Comment (by catalyst):

 Replying to [comment:1 nickm]:
 > Could we reuse config_line_t, or is there a mismatch?
 I think it would need to be extended or wrapped to add the numeric result
 code on each line. Some commands like `MAPADDRESS` can have multiple
 result codes in a single response. (This doesn't conform with `control-
 spec.txt` currently, but that's a different problem.) Also some replies
 are one key-value pair per line (e.g., `250-key=value` from `GETCONF`),
 but some contain multiple key-value pairs (e.g., the `ORCONN` async
 reply).

 Also for async events, there's a separate numeric event type code that's
 distinct from the `650` reply code.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30984#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs