[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #1795 [Tor Relay]: Prop 174: Optimistic Data for Tor: Server Side

#1795: Prop 174: Optimistic Data for Tor: Server Side
-------------------------+--------------------------------------------------
 Reporter:  nickm        |          Owner:  iang               
     Type:  enhancement  |         Status:  needs_review       
 Priority:  normal       |      Milestone:  Deliverable-Mar2011
Component:  Tor Relay    |        Version:                     
 Keywords:  prop174      |         Parent:  #1849              
   Points:               |   Actualpoints:                     
-------------------------+--------------------------------------------------

Comment(by nickm):

 So the right fixes, fwict, are:
   * Make the circuit_consider_sending_sendme unconditional again.   The
 circuit-level sendme shouldn't depend on the stream at all.
   * The stream-level connection_edge_consider_sending_sendme() should
 probably actually move completely: it belongs in a new
 "connection_edge_flushed_some()".  We shouldn't actually be sending relay
 sendmes just because we're queueing cells on the outbuf!  But that's
 another bug.
   * The connection_start_writing() check should probably be more like:

 {{{
    IF_HAS_BUFFEREVENT(conn, {
        connection_start_writing
    }) ELSE_IF_NO_BUFFEREVENT {
        if (conn->write_event)
            connection_start_writing
    }
 }}}

 I'm going to grab the patch stick on this stuff now.  Should have a patch
 for you rsn.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1795#comment:26>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs