Re: [tor-bugs] #2733 [Vidalia]: Option to filter message log output by search term

["Tor Bug Tracker & Wiki" <torproject-admin@xxxxxxxxxxxxxx>]

#2733: Option to filter message log output by search term
-------------------------+--------------------------------------------------
 Reporter:  chiiph       |          Owner:  sebb          
     Type:  enhancement  |         Status:  needs_revision
 Priority:  minor        |      Milestone:                
Component:  Vidalia      |        Version:                
 Keywords:               |         Parent:                
   Points:               |   Actualpoints:                
-------------------------+--------------------------------------------------
Changes (by chiiph):

  * status:  needs_review => needs_revision


Comment:

 * You've missed a couple of {, look for "_logFilter{".
 * The "type in separate line" does not apply to inline defined methods
 (i.e. bool ExpTree::eval doesn't apply to that rule), sorry for not being
 clear enough.
 * You should squash the different commits into one (or several, as you see
 fit). Having commits like this: "Implement X", "Fix X according to Y",
 "Fix again X according to Z", can be modified to be either: "Implement X"
 (with all the fixes included), or "Implement X.1", "Add functionality for
 X.2". Check git rebase -i.
 * You need to add a changes file. See the changes directory, try to follow
 that format.

 If you just give me a branch name in your repo, you don't need to post
 format-patches, I will just merge your branch in the end.

 Great work! We are almost there :)

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2733#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs