[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #9268 [TorBrowserButton]: Resizing the browser window does not take size of taskbars and DPI into account

#9268: Resizing the browser window does not take size of taskbars and DPI into
account
-------------------------+-------------------------------------------------
     Reporter:  gk       |      Owner:  mikeperry
         Type:  defect   |     Status:  needs_revision
     Priority:  major    |  Milestone:
    Component:           |    Version:
  TorBrowserButton       |   Keywords:  tbb-fingerprinting,
   Resolution:           |  GeorgKoppen201403R, MikePerry201403R
Actual Points:           |  Parent ID:
       Points:           |
-------------------------+-------------------------------------------------

Comment (by gk):

 Pushed bug_9268_finalkludge with the latest and greatest code to my
 torbutton repo for testing + attached the resulting xpi.

 cypherpunks: The code looks good so far, thanks. I am not really convinced
 yet that we need the kludge part. For instance, in which cases should the
 outerHeight and the innerHeight be equal? You hint at maximized windows.
 But even there you have browser chrome (toolbars etc.). Maybe you mean
 fullscreen mode? But even then Tor Browser is never starting in fullscreen
 mode nor with missing browser chrome. At least I can currently not think
 of a use-case in which it would do that. And I don't understand the no
 window case either. If we have no window then there are window properties
 either. Which in turn does not work with all the calculations we do. So:
 What's that fancy kludge thingy for? Maybe it has to do with the
 "randomish outer{Width,Height}"? What do you mean with that? Is there
 something in the Mozilla code that makes you believe there is such kind of
 randomness?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9268#comment:34>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs