[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #12218 [EFF-HTTPS Everywhere]: toolbar_button.js should do more null checks

#12218: toolbar_button.js should do more null checks
--------------------------------------+--------------------------
     Reporter:  cypherpunks           |      Owner:  zyan
         Type:  defect                |     Status:  needs_review
     Priority:  minor                 |  Milestone:
    Component:  EFF-HTTPS Everywhere  |    Version:
   Resolution:                        |   Keywords:  rulesets
Actual Points:                        |  Parent ID:
       Points:                        |
--------------------------------------+--------------------------

Comment (by mcs):

 Replying to [comment:9 zyan]:
 > Hey mcs, the patch looks good but please use curly braces around all
 blocks.

 Fixed.

 > Also, if you don't mind submitting the patch as a Github pull request,
 that would be preferred. https://github.com/efforg/https-everywhere/pulls

 Done.  Thanks for pointing me in the right direction for patch submission.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12218#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs