[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #18458 [Tor]: relax directory checking for unix sockets.

#18458: relax directory checking for unix sockets.
--------------------+------------------------------------
 Reporter:  weasel  |          Owner:
     Type:  defect  |         Status:  needs_review
 Priority:  Medium  |      Milestone:  Tor: 0.2.8.x-final
Component:  Tor     |        Version:  Tor: 0.2.8.1-alpha
 Severity:  Normal  |     Resolution:
 Keywords:          |  Actual Points:
Parent ID:          |         Points:
  Sponsor:          |
--------------------+------------------------------------

Comment (by teor):

 Code review:

 This code looks like it works. It also simplifies some of the existing
 logic.

 The log message that mentions "StrictDirModes" should probably say
 "RelaxDirModeCheck".

 Thanks for the unit test. The unit tests could check that relaxing the
 directory mode check works. (And that no option and NoRelaxDirModeCheck do
 the check as they did in previous versions.)

 As we are past the feature freeze date for 0.2.8, I'm tentatively placing
 this in 0.2.9. Please check with Nick if you think it should be in 0.2.8.

 I think Yawning wrote the original code - at the very least, he
 understands unix sockets better than I do. I'd also like him to review it
 if he can.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18458#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs